add test cases for ZIP files where the local file header and central directory have different data in the "compression method" field.#29
Merged
folkertdev merged 1 commit intomainfrom Apr 7, 2026
Conversation
Collaborator
Author
|
of course, there are many other fields in the local file header/central directory that should be in sync and possibly are not. I could add more test cases, but perhaps a single one is enough. |
folkertdev
force-pushed
the
mismatched_compression_local_central_directory
branch
3 times, most recently
from
8e60578 to
914df9a
Compare
directory have different data in the "compression method" field.
folkertdev
force-pushed
the
mismatched_compression_local_central_directory
branch
from
914df9a to
aa223c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The central directory and the local file header can have different information in various fields. These should be detected and reported by a linter, just as some other programs do (see the readme file for more information).
As an extension (or in "do whatever it takes" mode) it might make sense to try to be smart to try and detect what compression is actually used (but not when data is merely stored, as that is probably intentional) and use that when declared compression fails.