Update the old plots in the README.md and add benchmarks to docs - #170
Update the old plots in the README.md and add benchmarks to docs#170efaulhaber wants to merge 17 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
- Coverage 84.59% 83.94% -0.66%
==========================================
Files 15 15
Lines 792 791 -1
==========================================
- Hits 670 664 -6
- Misses 122 127 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Why are there no CPU results for TLSPH? |
It's in the comments. I would like to first merge trixi-framework/TrixiParticles.jl#1256 for better performance on large CPUs. I will add these numbers in the next PR. |
dcda762 to
53fbba8
Compare
efaulhaber
left a comment
There was a problem hiding this comment.
Codex Review
Adds CPU benchmark data and plotting for WCSPH implementations and update strategies, generates those plots during documentation builds, and refreshes README benchmark content.
This is an AI-generated code review. Please verify the findings and summary before acting on them.
Review generated by codex-pr-review
efaulhaber
left a comment
There was a problem hiding this comment.
Codex Review
The PR adds update-strategy and implementation benchmark runners, plots, documentation, and published benchmark assets. The new update comparison does not use identical workloads across strategies and can fail for supported radius values because of a fixed neighbor-list capacity.
This is an AI-generated code review. Please verify the findings and summary before acting on them.
Review generated by codex-pr-review
efaulhaber
left a comment
There was a problem hiding this comment.
Codex Review
The PR expands benchmark runners and plots, adds update-strategy comparisons and benchmark documentation, and improves deterministic point-cloud perturbation.
This is an AI-generated code review. Please verify the findings and summary before acting on them.
Review generated by codex-pr-review
This PR
sort_neighbor_lists = truein the benchmarks. This is the default, but having this kwarg allows us totrixi_includethis benchmark and setting it to false until AMDGPU.jl properly implements sorting.Preview at https://trixi-framework.org/PointNeighbors.jl/previews/PR170/.
Note that the README.md doesn't show the new plots until merged into main, but they can be previewed on the starting page of the docs linked above.