Feature/signal api#95
Merged
Merged
Conversation
Implement PHP-facing signal handling: Signal backed enum (int) with 14 cases and signal() function returning Future<Signal>. Supports optional Completable cancellation parameter. Known issue: 152-byte memory leak under cancellation path.
…ixes - Save and restore Zend sigaction handlers around libuv signal lifecycle to prevent "handler was replaced" warning from zend_signal_deactivate() - Forward signals to SIGG(handlers) in libuv callback so pcntl and Zend timeout handlers still work when libuv owns the signal - Add get_gc to Future to expose exception/result to cycle collector, fixing leak caused by Future↔Exception circular reference via trace - Break cancel_cb↔timeout circular reference by releasing cancellation_obj after signal cancellation callback fires - Fix test 002 to use Signal::SIGUSR1->value instead of undefined SIGUSR1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.