NAS-141990 / 27.0.0-BETA.1 / api_client: fix midclt login-failure reporting - #84
Open
anodos325 wants to merge 1 commit into
Open
NAS-141990 / 27.0.0-BETA.1 / api_client: fix midclt login-failure reporting#84anodos325 wants to merge 1 commit into
anodos325 wants to merge 1 commit into
Conversation
anodos325
commented
Jul 29, 2026
anodos325
commented
Contributor
- Print login failures to stderr and exit 1 instead of stdout/exit 0, which made shell callers reading the exit code or stdout see success.
- Replace the confusing ConfigParser error raised when key material isn't a raw key or JSON with a clear message naming the accepted formats. Diagnostics raised by _parse_ini_config itself are unchanged.
- Print login failures to stderr and exit 1 instead of stdout/exit 0, which made shell callers reading the exit code or stdout see success. - Replace the confusing ConfigParser error raised when key material isn't a raw key or JSON with a clear message naming the accepted formats. Diagnostics raised by _parse_ini_config itself are unchanged.
bugclerk
changed the title
yocalebo
approved these changes
Jul 29, 2026
themylogin
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.