You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The same limit (OPENDMARC_ARCSEAL_MAX_LONG_VALUE_LEN) also exists in opendmarc-arcseal.h and controls the size of the signature_value field in struct arcseal. Bumping only the .c constant left the struct field at 512 bytes, so values from large-key signatures would still be silently truncated. PR Fix ARC header parsing crashes: SIGABRT on malformed tokens and SIGSEGV on large RSA key signatures #296 bumps both constants, and raises the limit to 2048 (covering RSA 4096-bit and larger).
A second, independent crash path existed where a token with no = sign (e.g. ARC-Seal: i=1; none) caused NULL to be passed to strip_whitespace(), triggering assert(string != NULL) → SIGABRT. That needed a separate guard.
The same issues also existed in the opendmarc-arcares.c parser, which was not covered here.
Closing in favour of #296, which addresses all of the above. Thanks again for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enough for 3072 bit key signatures. Should fix #183.