feat(linter): Rule which warns when you could've used NoGcScope
#913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliassjogreen
force-pushed
the
feat/lint-can-use-no-gc-scope
branch
from
cbe2a1d to
c892506
Compare
aapoalas
previously approved these changes
Dec 13, 2025
Member
aapoalas
left a comment
aapoalas
left a comment
There was a problem hiding this comment.
LGTM, and awesome work! This is really damn good stuff <3 Left a few notes, comments, and/or suggestions.
eliassjogreen
force-pushed
the
feat/lint-can-use-no-gc-scope
branch
from
f3d280e to
5cbb99a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lint which checks if you are taking
GcScopedespite only needingNoGcScope. Fixed all of the edge cases I found until the engine had no false-positives and fixed a few places in the vm where we usedGcScopewhere we could've usedNoGcScope. I left two places with theGcScopebecause I was unsure if it needed it because of async or as a placeholder for the future, these are excluded with a#[allow]directive.