test: use a platform-appropriate absolute path in normalize_cli_path …#582
Merged
Conversation
…test normalize_cli_path_handles_absolute_and_relative hardcoded C:\nonexistent_abs_path as its absolute-path input, but Path::is_absolute only treats drive-letter paths as absolute on Windows; on macOS the path counts as relative and gets joined onto the cwd, failing the assertion. The test had never actually run on macOS before because the whole test target failed to compile until the preceding commit. Pick the absolute path per platform via cfg so the test exercises the same behavior everywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…test
normalize_cli_path_handles_absolute_and_relative hardcoded C:\nonexistent_abs_path as its absolute-path input, but Path::is_absolute only treats drive-letter paths as absolute on Windows; on macOS the path counts as relative and gets joined onto the cwd, failing the assertion. The test had never actually run on macOS before because the whole test target failed to compile until the preceding commit.
Pick the absolute path per platform via cfg so the test exercises the same behavior everywhere.