fix: cover ToggleVisibility in send_ipc_command match under cfg(test)#584
Merged
Conversation
The IpcCommand::ToggleVisibility variant is cfg-gated on any(linux, windows, test) so that decode_execute_payload and its unit tests compile on macOS, but the corresponding match arm in send_ipc_command was only gated on any(linux, windows). Building the test target on macOS therefore hit E0004 (non-exhaustive patterns), which made every test in the paperback crate uncompilable there. Align the match arm cfg with the variant cfg so workspace-wide `cargo test` builds on macOS again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IpcCommand::ToggleVisibility variant is cfg-gated on any(linux, windows, test) so that decode_execute_payload and its unit tests compile on macOS, but the corresponding match arm in send_ipc_command was only gated on any(linux, windows). Building the test target on macOS therefore hit E0004 (non-exhaustive patterns), which made every test in the paperback crate uncompilable there.
Align the match arm cfg with the variant cfg so workspace-wide
cargo testbuilds on macOS again.