maintenance: add proper health checks and alerting#44
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to improve operational robustness by adding service health checks plus Grafana alert provisioning, and by making docker-compose rollouts sensitive to config changes.
Changes:
- Provision Grafana alert rules and mount them into Grafana.
- Add docker-compose “config-hash” labels and compute hashes from rendered configs/assets to trigger recreation on config changes.
- Replace the readiness check with healthcheck-based checks using dedicated
hc-*containers; add blackbox probing config in Alloy.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/service/deploy.go | Adds Grafana alert deployment, config-hash computation for compose templating, and a new healthcheck-based readiness gate. |
| internal/service/update.go | Ensures Grafana alerts are deployed during update before recomposing services. |
| internal/service/service_test.go | Updates dry-run log expectations to match the new readiness-check behavior. |
| internal/service/assets/docker-compose.yaml.tmpl | Mounts Grafana alert provisioning dir, adds config-hash labels, and introduces hc-* healthcheck containers. |
| internal/service/assets/alloy.config.tmpl | Adds blackbox exporter/scrape configuration intended to support alerting and health probing. |
| internal/service/assets/grafana-alerts.yaml | Introduces new Grafana-managed alert rules for core services. |
tschaefer
force-pushed
the
tschaefer/maintenance/healthz
branch
3 times, most recently
from
3dd1779 to
f94f770
Compare
tschaefer
force-pushed
the
tschaefer/maintenance/healthz
branch
from
f94f770 to
6841f79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.