Change structure of examples, test, bench, and test-examples to follow the one from src#481
Open
Change structure of examples, test, bench, and test-examples to follow the one from src#481
examples, test, bench, and test-examples to follow the one from src#481Conversation
…perly match src structure
9c54126 to
d54e402
Compare
Member
|
I object to the renaming of the Maybe you want to prefix them with The rest looks quite reasonable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that there are some inconsistencies in the naming of test/bench executables of
linear-base. In particular:src/Data.<structure>.Mutablewhile the associated test/bench module was<exe>/Data.Mutable.<structure>benchwas missing a topBenchmodule name component, so names could conflict with the ones insrctestmodules for array were missing theArraymodule name componentHere's the exhaustive changelog: