-
Notifications
You must be signed in to change notification settings - Fork 18
1538 investigate and remove superseded blanket switches #4140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jonmaddock
wants to merge
5
commits into
main
Choose a base branch
from
1538-investigate-and-remove-superseded-blanket-switches2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
43dd361
Rename blktmodel to i_blanket_type_stellarator
jonmaddock 896d8ce
Remove blkttype and add options to i_blanket_type_stellarator
jonmaddock 54399ec
Remove undefined stellarator variables
jonmaddock 02bef12
Add HCPB blanket selection to stellarator regression tests
jonmaddock 4e310cc
Skip stellarator_helias as it no longer converges
jonmaddock File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -250,12 +250,14 @@ All items external to the fusion power core (buildings, turbines, power conversi | |
| ## Stellarator Blanket | ||
|
|
||
| There are two blanket modules implemented in stellarator-PROCESS at the moment, | ||
| - `blktmodel = 1`: Calls the KIT HCPB model | ||
| - `blktmodel = 0` AND `ipowerflow=1`: Calls a "simple" model (`ipowerflow=0` is even simpler and not advised) | ||
| - `i_blanket_type_stellarator = 0` AND `ipowerflow=1`: Calls a "simple" model (`ipowerflow=0` is even simpler and not advised) | ||
| - `i_blanket_type_stellarator = 1`: Calls the KIT HCPB model | ||
| - `i_blanket_type_stellarator = 2`: WCLL; efficiency taken from WP13-DAS08-T02, EFDA_D_2M97B7 | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not rendering as a bullet point list when I look at it |
||
| - `i_blanket_type_stellarator = 3`: HCLL; efficiency taken from WP12-DAS08-T01, EFDA_D_2LLNBX and M. Kovari 2016 "PROCESS": A systems code for fusion power plants - Part 2: Engineering https://www.sciencedirect.com/science/article/pii/S0920379616300072 Feedheat & reheat cycle assumed | ||
| - `i_blanket_type_stellarator = 4`: HCPB; efficiency taken from WP12-DAS08-T01, EFDA_D_2LLNBX and M. Kovari 2016 "PROCESS": A systems code for fusion power plants - Part 2: Engineering https://www.sciencedirect.com/science/article/pii/S0920379616300072 Feedheat & reheat cycle assumed | ||
|
|
||
| The KIT HCPB model is documented elsewhere, for the simple module the following set of input parameters should be provided: | ||
| ``` | ||
| blkttype = 0,1,2 (only relevant for mass calculations) | ||
| f_p_blkt_multiplication = 1.18 *Energy multiplication in blanket and shield | ||
| eta_coolant_pump_electric = 1. *Electrical efficiency of primary coolant pumps | ||
| fblbe = 0.47 *Beryllium fraction of blanket by volume (only relevant for mass calculations) | ||
|
|
@@ -270,7 +272,7 @@ p_blkt_coolant_pump_mw = 120. *Blanket coolant mechanical pumping power (MW) | |
| p_fw_coolant_pump_mw = 56. *First wall coolant mechanical pumping power (MW) | ||
| p_div_coolant_pump_mw = 24. *Divertor coolant mechanical pumping power (MW) | ||
| i_thermal_electric_conversion = 2 *Switch for power conversion cycle (2: user input thermal-electric efficiency) | ||
| f_a_blkt_cooling_channels = 0.1 *Coolant void fraction in blanket (blktmodel=0) (only relevant for mass calculations) | ||
| f_a_blkt_cooling_channels = 0.1 *Coolant void fraction in blanket (i_blanket_type_stellarator=0) (only relevant for mass calculations) | ||
| vfshld = 0.6 *Coolant void fraction in shield | ||
| declblkt = 0.075 *Neutron decay length in blanket area (m) | ||
| declfw = 0.075 *Neutron decay length in first wall (m) | ||
|
|
@@ -291,7 +293,7 @@ vgap = 0. *Vertical gap between x-point and divertor (m) | |
|
|
||
| The simple stellarator blanket module is largely reduced to calculating masses given on blanket and shield sizes as defined in the input file. | ||
| It also calculates neutron heat depositions based on the neutron decay length (this enters the cost function via shield pumping powers e.g.). | ||
| Most of the blanket constraints implemented in tokamak PROCESS, namely `icc=52,53,54,55` are not available with `blktmodel = 0` and the KIT HCPB model, `blktmodel = 1` should be used instead. | ||
| Most of the blanket constraints implemented in tokamak PROCESS, namely `icc=52,53,54,55` are not available with `i_blanket_type_stellarator = 0` and the KIT HCPB model, `i_blanket_type_stellarator = 1` should be used instead. | ||
| Note, that PROCESS also features other blanket models (HCLL, WCLL) and thermohydraulic blanket models but they are not yet available for stellarators. | ||
|
|
||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not generic enough. A small sentence to discern between setting the blanket for a tokamak and a stellarator is needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have consistency with whether we're using "blanket" or "blkt" in variable names?
There's another switch
i_blkt_coolant_type. I don't mind which we use but I think it should be consistent.