Draft
Conversation
…anization and maintainability
… and profiles to DetailedPhysics class
… DetailedPhysics class
…eron, electron-triton, and electron-alpha interactions in plasma
…ctions in DetailedPhysics class
…s in DetailedPhysics class
je-cook
reviewed
Mar 30, 2026
| ) | ||
|
|
||
| @staticmethod | ||
| def plot_larmor_radius_profile(axis: plt.Axes, mfile_data: mf.MFile, scan: int): |
Collaborator
There was a problem hiding this comment.
instead of moving this plot functions wholesale could you just move the contents that is not from the mfile so you end up with a function and a method.
The function still takes the mfile and sets up the class so that you can then call whatever plotting method you want and the data is pulled from the class.
The function could still live in plot_proc and might become some reusable mechanic that can be used by multiple things for a given class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds several new plasma physics variables to the
physics_variables.pydata structure, primarily focused on collision times, collision frequencies, mean free paths, and resistivity profiles for various plasma species. These additions enhance the granularity and detail of plasma modeling, especially for electron interactions with deuterons, tritons, and alpha particles.New plasma variable additions:
Added profiles for Spitzer classical resistivity, electron-alpha Spitzer slowing down time, and various collision times, collision frequencies, and mean free paths between electrons and other plasma species (deuterons, tritons, alpha particles) to the data structure (
process/data_structure/physics_variables.py).Initialization updates:
Updated the
init_physics_variablesfunction to include initialization and zeroing of the new plasma variable profiles and to ensure these new variables are properly set up as empty lists or default values (process/data_structure/physics_variables.py).Checklist
I confirm that I have completed the following checks: