-
Notifications
You must be signed in to change notification settings - Fork 818
Entity Actions, v16 & v17 #7681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2233d8f to
623bd06
Compare
…and verified code samples. Formatting improvements. Additional clarity around entity action permissions.
623bd06 to
0bb891b
Compare
Removed reference to "xgrid" (unsure what that meant here)
I thought it best to flesh out the example
since the current backoffice is now v17. Removed "Umb.DocumentRecycleBin.Restore" entry, as doesn't exist.
for consistency throughout the article.
as the flow felt confusing to display the default UI after mentioning it can be replaced.
Remove the `config` part as it does not exist in the codebase.
leekelleher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the technical contents. I have made changes to the code snippets, (for consistency and TypeScript support).
@sofietoft I have left a comment about the extra anchor tags.
From a technical perspective, I am happy with these changes.
Thank you @bszyman for the herculean effort you've put into this! 💪 #h5yr
16/umbraco-cms/customizing/extending-overview/extension-types/entity-actions.md
Show resolved
Hide resolved
16/umbraco-cms/customizing/extending-overview/extension-types/entity-actions.md
Outdated
Show resolved
Hide resolved
16/umbraco-cms/customizing/extending-overview/extension-types/entity-actions.md
Outdated
Show resolved
Hide resolved
16/umbraco-cms/customizing/extending-overview/extension-types/entity-actions.md
Outdated
Show resolved
Hide resolved
sofietoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @bszyman !
I've reviewed the article, adding a few suggestions here and there.
Let me know if something doesn't make sense.
Also, calling them "fly-out" menus - is that something you have discussed in the community docs team? To my knowledge, we haven't called the menus this before, and I just want to make sure we keep it consistent throughout the repository.
16/umbraco-cms/customizing/extending-overview/extension-types/entity-actions.md
Outdated
Show resolved
Hide resolved
16/umbraco-cms/customizing/extending-overview/extension-types/entity-actions.md
Show resolved
Hide resolved
16/umbraco-cms/customizing/extending-overview/extension-types/entity-actions.md
Outdated
Show resolved
Hide resolved
16/umbraco-cms/customizing/extending-overview/extension-types/entity-actions.md
Outdated
Show resolved
Hide resolved
16/umbraco-cms/customizing/extending-overview/extension-types/entity-actions.md
Outdated
Show resolved
Hide resolved
16/umbraco-cms/customizing/extending-overview/extension-types/entity-actions.md
Show resolved
Hide resolved
16/umbraco-cms/customizing/extending-overview/extension-types/entity-actions.md
Outdated
Show resolved
Hide resolved
…entity-actions.md Co-authored-by: sofietoft <[email protected]>
…entity-actions.md Co-authored-by: sofietoft <[email protected]>
…entity-actions.md Co-authored-by: sofietoft <[email protected]>
…entity-actions.md Co-authored-by: sofietoft <[email protected]>
…entity-actions.md Co-authored-by: sofietoft <[email protected]>
|
@sofietoft - Thanks for your review and feedback! All excellent suggestions! I committed all of them, and tweaked the sentence around the |
Reword description for clarity and conciseness.
sofietoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work you put into this @bszyman ! 🙏
Much, much appreciated.
I'll merge it 🎉
📋 Description
Update Entity Actions article to support Umbraco v16, v17. Refreshed and verified code samples. Formatting improvements. Additional clarity around entity action permissions.
📎 Related Issues (if applicable)
#7318
✅ Contributor Checklist
I've followed the Umbraco Documentation Style Guide and can confirm that:
Product & Version (if relevant)
v16, v17
Deadline (if relevant)
N/A
📚 Helpful Resources