Skip to content

Fix builtin browser failing to start with 'NoneType' object has no attribute 'browser_type' #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Liang-HZ wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −2
Open

Fix builtin browser failing to start with 'NoneType' object has no attribute 'browser_type' #2104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions crawl4ai/browser_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,19 @@ def __init__(
cdp_url (str or None): CDP URL to connect to the browser. Default: None.
browser_config (BrowserConfig): Configuration object containing all browser settings. Default: None.
"""
if browser_config is None:
# The legacy keyword arguments above are still part of this
# signature and are documented in the docstring; honour them
# instead of raising an opaque AttributeError on ``None``.
browser_config = BrowserConfig(
browser_type=browser_type,
user_data_dir=user_data_dir,
headless=headless,
host=host,
debugging_port=debugging_port,
cdp_url=cdp_url,
)

self.browser_type = browser_config.browser_type
self.user_data_dir = browser_config.user_data_dir
self.headless = browser_config.headless
Expand Down
7 changes: 5 additions & 2 deletions crawl4ai/browser_profiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1202,12 +1202,15 @@ async def launch_builtin_browser(self,
os.makedirs(user_data_dir, exist_ok=True)

# Create managed browser instance
managed_browser = ManagedBrowser(
browser_config = BrowserConfig(
browser_type=browser_type,
user_data_dir=user_data_dir,
headless=headless,
debugging_port=debugging_port,
)
managed_browser = ManagedBrowser(
browser_config=browser_config,
logger=self.logger,
debugging_port=debugging_port
)

try:
Expand Down