Skip to content

ICU-23371 Deduplicate keyOffsets and key32Offsets in Table#3941

Merged
mihnita merged 1 commit intounicode-org:mainfrom
gvictor:ICU-23371-dedup-table-offsets
Apr 20, 2026
Merged

ICU-23371 Deduplicate keyOffsets and key32Offsets in Table#3941
mihnita merged 1 commit intounicode-org:mainfrom
gvictor:ICU-23371-dedup-table-offsets

Conversation

@gvictor
Copy link
Copy Markdown
Collaborator

@gvictor gvictor commented Apr 14, 2026

It saves around 50kB when en-US is used as the default locale, after calling basic APIs, e.g. Number.getInstance()

Checklist

  • Required: Issue filed: ICU-NNNNN
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable
  • Approver: Feel free to merge on my behalf

It saves around 50kB when en-US is used as the default locale,
after calling basic APIs, e.g. Number.getInstance()
@markusicu markusicu self-requested a review April 16, 2026 15:48
@mihnita mihnita merged commit 0d84e02 into unicode-org:main Apr 20, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants