fix(build)!: Remove default target - #450
Open
jedevc wants to merge 1 commit into
Open
Conversation
dragosgheorghioiu
previously approved these changes
Aug 14, 2026
dragosgheorghioiu
left a comment
dragosgheorghioiu
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Reviewed-by: Dragos Gheorghioiu <dragosg@unikraft.com>
Approved-by: Dragos Gheorghioiu <dragosg@unikraft.com>
craciunoiuc
previously approved these changes
Aug 14, 2026
craciunoiuc
left a comment
craciunoiuc
left a comment
Contributor
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.com>
Approved-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.com>
We're now a multi-platform shop: we support amd64 and also aarch64. So, to support them equally - no more build defaults. We now *require* that when building an image the user has specified an architecture: - For building an image, very little changes if users have a `runtime`, we still default to using all of them. Users can still override it using the `targets:` key (or the new `--arch` flag). - For building a rom, users will now need to set the `targets:` key (or `--arch`) *explicitly*. This is a breaking change, but this was originally done under my previous (wrong) assumption that ROMs would be platform-independent. They really aren't, so I think the breaking change is justified, and creates a simpler-to-understand config. Signed-off-by: Justin Chadwell <justin@unikraft.com>
jedevc
dismissed stale reviews from craciunoiuc and dragosgheorghioiu
via
August 14, 2026 16:33
b8fc20d
jedevc
force-pushed
the
jedevc/remove-default-targets
branch
from
August 14, 2026 16:33
6cacc50 to
b8fc20d
Compare
craciunoiuc
approved these changes
Aug 14, 2026
craciunoiuc
left a comment
craciunoiuc
left a comment
Contributor
There was a problem hiding this comment.
I agree even harder now.
Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.com>
Approved-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're now a multi-platform shop: we support amd64 and also aarch64.
So, to support them equally - no more build defaults. We now require that when building an image the user has specified an architecture:
runtime, we still default to using all of them. Users can still override it using thetargets:key (or the new--archflag).targets:key (or--arch) explicitly.This is a breaking change, but this was originally done under my previous (wrong) assumption that ROMs would be platform-independent. They really aren't, so I think the breaking change is justified, and creates a simpler-to-understand config.
Before:
After: