Implement MiCA-Required Field Validations for EEA Users - #33
Open
Megamind51 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the EU TIN validation layer to better align natural-person identifiers with MiFID II/ESMA National Client Identifier requirements (as referenced in the PR description), by expanding per-country formats and adding internal checksum validation where appropriate.
Changes:
- Expanded accepted TIN/NCI formats for CY, GR, LI, NL, and SI in the per-country validator configuration.
- Added internal validation algorithms for NL (BSN 11-proof) and SI (EMŠO structure/check digit) and wired them into internal validation flow.
- Updated internal validation to optionally run a country-specific
validate()function after a format match.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/validators/validators-by-country.js |
Adds NL/SI checksum validators and updates country format configs (CY/GR/LI/NL/SI). |
src/validators/eu-tin-validator.js |
Enhances internal validation to run optional per-country validation callbacks. |
test/src/validators/test-cases-by-country.js |
Updates test vectors/masked outputs to reflect the new accepted formats and validations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Megamind51
force-pushed
the
support/implement-mica-required-field-validations-for-eea-users
branch
from
July 7, 2026 13:14
9d6e162 to
1b29951
Compare
FrancoOrtiz74
suggested changes
Jul 14, 2026
Megamind51
force-pushed
the
support/implement-mica-required-field-validations-for-eea-users
branch
from
July 15, 2026 16:04
1b29951 to
9cbd54d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement MiCA-Required Field Validations for EEA Users
This issue involves validating identity fields to meet the requirements set by the ESMA MiFID II National Client Identifier Table. The validation ensures compliance with Commission Delegated Regulation (EU) 2017/590.
Ticket:
https://uphold.atlassian.net/browse/BKO-6685