Replace CI bash loop with Makefile#12
Merged
Merged
Conversation
Greptile SummaryReplaces the verbose bash arg-extraction loop in
Confidence Score: 5/5Safe to merge — the change is a straightforward refactor of CI shell logic into a Makefile with no behavioral changes to the build or test pipeline. The Makefile faithfully replicates the original bash loop (env sourcing + awk arg extraction), the CI workflow change is minimal, and all downstream jobs remain unmodified. No files require special attention. Important Files Changed
Reviews (3): Last reviewed commit: "Address PR feedback: derive versions lis..." | Re-trigger Greptile |
The bash arg-extraction loop in ci.yml and the README was hard to read and not reusable locally. A Makefile replaces it with one-line commands: make build VERSION=8.4 make test VERSION=8.4 make all CI now invokes `make build` directly. README documents the same commands. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…oped tags - VERSIONS now expands from versions/*.env via wildcard, so adding a new PHP version no longer requires updating the Makefile alongside ci.yml matrix. - Default IMAGE is now utopia-base-test:$(VERSION) so 'make all' produces three distinct tags instead of overwriting :latest each iteration. - 'make clean' iterates VERSIONS for the same reason. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
versions/<X.Y>.envand turning each key into a--build-argflag was hard to read and not reusable locally.Makefileexposingmake build,make test, andmake all.ci.ymlnow callsmake build VERSION=… IMAGE=utopia-base-testinstead of inlining shell.Stacked on top of #11 — please review/merge that one first.
Test plan
make buildmake test VERSION=8.4passes locally withcontainer-structure-testinstalled🤖 Generated with Claude Code