tail: fix panic on header write error#12279
Open
gabrielhnf wants to merge 1 commit into
Open
Conversation
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11993
Problem
When running tail on multiple files and redirecting output to a full device (e.g. /dev/full), uutils panics instead of exiting gracefully:
Instead of the correct GNU behavior:
Cause
HeaderPrinter::printusedprintln!to write the==> file <==headers to stdout.println!panics on write failure rather than returning a Result, so any write error (such as ENOSPC from/dev/full) caused an unhandled panic instead of a clean error message.Fix
Replaced
println!in HeaderPrinter withwrite_allandflushon a locked stdout, both of which returnio::Result. The methods now returnUResult<()>and propagate write errors upstream instead of panicking.