dd: name the failing operation and count the read that failed to write - #14071
dd: name the failing operation and count the read that failed to write#14071igorgbr wants to merge 5 commits into
Conversation
A failed copy reported `IO error: <errno>` without saying whether the read or the write failed, or on which file. It also dropped the record that had been read when the write failed, so `records in` was one short.
Merging this PR will degrade performance by 3.77%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | dd_copy_default |
32.2 ms | 33.6 ms | -4.21% |
| ❌ | Simulation | dd_copy_4k_blocks |
2.5 ms | 2.7 ms | -3.86% |
| ❌ | Simulation | dd_copy_with_seek |
4.8 ms | 5 ms | -3.76% |
| ❌ | Simulation | dd_copy_with_skip |
4.7 ms | 4.9 ms | -3.69% |
| ❌ | Simulation | dd_copy_8k_blocks |
1.8 ms | 1.9 ms | -3.35% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing igorgbr:dd/report-stats-on-io-error (22df584) with main (1a6fb19)2
Footnotes
-
390 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(94d87a0) during the generation of this report, so 1a6fb19 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
|
GNU testsuite comparison: |
|
The remaining CI failure on It looks like a flaky test, but I don't have permission to re-run the job. Could someone with access re-run it or advise if anything else is needed? Thanks! |
Also renames the test directory to a word cspell already knows, so the workspace dictionary does not need an entry.
|
None of the GnuTests regressions come from this PR:
That comes from 7f9b9a6 ("dd: reject a number that does not fit in u64"),
|
Follow-up to eb7f437, which made a failed copy report its statistics.
Two differences from GNU remained: when the write fails, the block that was
read is dropped instead of counted, so
records inis one short; and themessage is
IO error: <errno>, without the operation or the file.dd_copynow returnsUResultso the error carries the operation and thefile name; the existing
?paths keep the old generic context.Refs #13092.