more: use OS errors instead of hardcoded locales

[Devel08]

This PR replaces hardcoded error message with native OS error

[codspeed-hq]

Merging this PR will degrade performance by 4.83%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 2 regressed benchmarks
✅ 355 untouched benchmarks
⏩ 50 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
❌	Simulation	numfmt_stream_to_si_precision	330.4 ms	348 ms	-5.05%
❌	Simulation	seq_formatted	166.3 ms	174.4 ms	-4.62%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing Devel08:more-use-os-error (86a2a6f) with main (259fdfc)²}

Footnotes

1. 50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on main (71ebb92) during the generation of this report, so 259fdfc was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[github-actions]

GNU testsuite comparison:

Note: The gnu test tests/rm/many-dir-entries-vs-OOM is now being skipped but was previously passing.
Congrats! The gnu test tests/dd/no-allocate is now passing!
Skip an intermittent issue tests/tail/tail-n0f (was skipped on 'main', now failing)

[oech3]

Where is the place more-error-is-directory cannot be replaced by os error? (Removing it at another PR is fine).

[Devel08]

File::open() doesn't throw an error when a file is a directory, thus we have to check that manually

[oech3]

EISDIR (or EPERM) is returned when read was called for directory. So the arm

coreutils/src/uu/more/src/more.rs

Lines 42 to 51 in 92cbd2f

	Self::IsDirectory(path) => {
	write!(
	f,
	"{}",
	translate!(
	"more-error-is-directory",
	"path" => path.quote()
	)
	)
	}

can be removed on many unix.

[Devel08]

yeah it's returned on read, but the message will look something like "more: Is a directory", the path will be missing, if we rely on the message that read returns, should we let read's message or the custom locale?

[oech3]

I'll fix this at different PR using format! or something else.

[RenjiSann]

You can use the map_err_context function of the FromIo trait. It basically adds context (usually the filename) before the error message