Skip to content

Revert "remove rust-version from fuzz" - #14105

Open
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:rust-version
Open

Revert "remove rust-version from fuzz"#14105
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:rust-version

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

uufuzz is published on crates.io, so we shouldn't remove rust-version from the package metadata.

@codspeed-hq

codspeed-hq Bot commented Aug 23, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 3.73%

⚡ 1 improved benchmark
✅ 356 untouched benchmarks
⏩ 50 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation du_deep_tree[(100, 3)] 2.1 ms 2 ms +3.73%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing xtqqczze:rust-version (814aa6b) with main (9986da4)

Open in CodSpeed

Footnotes

  1. 50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

github-actions Bot commented Aug 23, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)

@oech3

oech3 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Sorry. I don't understand. We can guarantee build with latest stable Rust without that metadata.

@sylvestre

Copy link
Copy Markdown
Contributor

@xtqqczze wdyt? :)

@sylvestre

Copy link
Copy Markdown
Contributor

in fuzz/ cargo publish --dry-run --workspace passed

@xtqqczze

Copy link
Copy Markdown
Contributor Author

@xtqqczze wdyt? :)

I don't see why we should remove rust-version from the package metadata, given that uufuzz is published.

@oech3

oech3 commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

I think we need to keep rust version of production small for legacy distributions with disadvantage of restriction for modern APIs. But we don't need to restrict modern APIs for test code.

@xtqqczze

Copy link
Copy Markdown
Contributor Author

But we don't need to restrict modern APIs for test code.

I think we can keep rust-version in uufuzz and bump it if we need to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants