fix(printf): do not panic when field width exceeds u16::MAX - #14117
fix(printf): do not panic when field width exceeds u16::MAX#14117VedantMadane wants to merge 2 commits into
Conversation
|
GNU testsuite comparison: |
Merging this PR will regress 1 benchmark
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | du_summarize_balanced_tree[(5, 4, 10)] |
16.1 ms | 16.8 ms | -3.86% |
| ⚡ | Simulation | seq_formatted |
175.6 ms | 160.1 ms | +9.65% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing VedantMadane:fix/issue-13850 (50a5154) with main (a9b64fc)2
Footnotes
-
274 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(71ebb92) during the generation of this report, so a9b64fc was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
Unable to generate the performance reportThere was an internal error while processing the run's data. We're working on fixing the issue. Feel free to contact us on Discord or at support@codspeed.io if the issue persists. |
|
some jobs are failing, could you please have a look? thanks |
- num_format.rs: manual padding path when width > u16::MAX - test_printf.rs: regression for %65536d Fixes uutils#13850 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
for more information, see https://pre-commit.ci
50a5154 to
a2efbc7
Compare
Summary
fix(printf): do not panic when field width exceeds u16::MAX
Changes
Fixes #13850