Skip to content

fix(printf): do not panic when field width exceeds u16::MAX - #14117

Open
VedantMadane wants to merge 2 commits into
uutils:mainfrom
VedantMadane:fix/issue-13850
Open

fix(printf): do not panic when field width exceeds u16::MAX#14117
VedantMadane wants to merge 2 commits into
uutils:mainfrom
VedantMadane:fix/issue-13850

Conversation

@VedantMadane

Copy link
Copy Markdown

Summary

fix(printf): do not panic when field width exceeds u16::MAX

Changes

  • num_format.rs: manual padding path when width > u16::MAX
  • test_printf.rs: regression for %65536d

Fixes #13850

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/cut/cut-huge-range is now being skipped but was previously passing.
Congrats! The gnu test tests/dd/no-allocate is now passing!
Congrats! The gnu test tests/tail/tail-n0f is now passing!

@codspeed-hq

codspeed-hq Bot commented Aug 24, 2026

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 131 untouched benchmarks
⏩ 274 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation du_summarize_balanced_tree[(5, 4, 10)] 16.1 ms 16.8 ms -3.86%
Simulation seq_formatted 175.6 ms 160.1 ms +9.65%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing VedantMadane:fix/issue-13850 (50a5154) with main (a9b64fc)2

Open in CodSpeed

Footnotes

  1. 274 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (71ebb92) during the generation of this report, so a9b64fc was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@codspeed-hq

codspeed-hq Bot commented Aug 24, 2026

Copy link
Copy Markdown

Unable to generate the performance report

There was an internal error while processing the run's data. We're working on fixing the issue. Feel free to contact us on Discord or at support@codspeed.io if the issue persists.

@sylvestre

Copy link
Copy Markdown
Contributor

some jobs are failing, could you please have a look? thanks

VedantMadane and others added 2 commits August 26, 2026 18:26
- num_format.rs: manual padding path when width > u16::MAX
- test_printf.rs: regression for %65536d

Fixes uutils#13850

Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

printf: panics on a numeric field width above 65535 (%65536d)

2 participants