clippy: fix inline_always lint #9963
Open
+0
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
No regressions in benchmarks |
sylvestre
reviewed
Jan 1, 2026
sylvestre
reviewed
Jan 1, 2026
Contributor
maybe because we don't have benchmarks covering these code paths ? ;) |
xtqqczze
force-pushed
the
clippy/inline_always
branch
from
bed45ff to
40939c8
Compare
Contributor
Author
I didn’t see any evidence that any measurement had been carried out for the existing usage. If performance issues do show up later, the attribute can always be added back at that point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rust-lang.github.io/rust-clippy/master/index.html#inline_always