fix(find): output nothing when -mindepth exceeds -maxdepth - #857
Open
Jorge-Polanco-Roque wants to merge 1 commit into
Open
fix(find): output nothing when -mindepth exceeds -maxdepth#857Jorge-Polanco-Roque wants to merge 1 commit into
Jorge-Polanco-Roque wants to merge 1 commit into
Conversation
`find -mindepth 2 -maxdepth 1` printed the max-depth entries instead of nothing. No depth can satisfy both bounds when min > max, and GNU find outputs nothing in that case; `WalkDir` clamps the range and still yields the max-depth entries, so guard `process_dir` to return early. Adds a regression test (fails without the fix). Fixes uutils#778
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #857 +/- ##
==========================================
+ Coverage 92.31% 92.33% +0.01%
==========================================
Files 35 35
Lines 7466 7485 +19
Branches 388 389 +1
==========================================
+ Hits 6892 6911 +19
Misses 433 433
Partials 141 141 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
please add a test in tests/test_find.rs too :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #778
Problem
When
-mindepthis greater than-maxdepth,findshould output nothing (no depth can be both>= mindepthand<= maxdepth), matching GNU find. uutils instead printed the max-depth entries:Cause
process_dirpasses both bounds toWalkDir::min_depth/max_depth. Whenmin_depth > max_depth,WalkDirdoes not yield the empty set — it effectively clamps the range and still yields entries at the max depth, so they leak through.Fix
Short-circuit in
process_dir: whenconfig.min_depth > config.max_depth, return early with no output, matching GNU find.Tests
Adds
find_mindepth_greater_than_maxdepth, which asserts empty output for-mindepth 2 -maxdepth 1. It fails without the fix (the max-depth entries are printed) and passes with it.cargo fmt --checkandcargo clippyare clean; normal min/max combinations are unaffected.