Skip to content

test: add a test for clicks on non visible grid columns#8587

Open
mcollovati wants to merge 2 commits intomainfrom
issues/testbench-2120-test_for_click_cound_in_treegrid
Open

test: add a test for clicks on non visible grid columns#8587
mcollovati wants to merge 2 commits intomainfrom
issues/testbench-2120-test_for_click_cound_in_treegrid

Conversation

@mcollovati
Copy link
Contributor

Adds a test that ensures Testbench is able to simulate a click on a cell that needs scrolling to be visible.

This test is related to vaadin/testbench#2120 and ensures that the change in Testbench prevents an exception when trying to click to an element in a Grid that is not yet scrolled into view.

@mcollovati
Copy link
Contributor Author

@TatuLund can provide additional context, if needed

@mcollovati mcollovati marked this pull request as draft February 2, 2026 11:15
@mcollovati
Copy link
Contributor Author

In draft until the change in Testbench gets merged and released

@mcollovati mcollovati force-pushed the issues/testbench-2120-test_for_click_cound_in_treegrid branch from 3460a81 to cb989a2 Compare February 2, 2026 11:20
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2026

@yuriy-fix
Copy link
Contributor

@mcollovati , do we still need this? Can it be closed?

@mcollovati
Copy link
Contributor Author

The related issue is still not fixed since the previous change was reverted.
There's a new attempt at vaadin/testbench#2158 that I'm currently testing locally.
It would be good if we could keep this PR and merge it if the Testbench change gets approved.

@mcollovati mcollovati force-pushed the issues/testbench-2120-test_for_click_cound_in_treegrid branch from cb989a2 to 6c928ed Compare March 5, 2026 10:21
@mcollovati
Copy link
Contributor Author

@yuriy-fix the test pass with the latest TB snapshot. It would be great if this PR could get merged after the next TB beta release is out. It will discover potential regressions in TB if scrolling to invisible elements behavior changes.

If it's OK for you, I'll update the PR to remove the TB version change after the repo updates to the next TB beta.

Adds a test that ensures Testbench is able to simulate
a click on a cell that needs scrolling to be visible.

Related to vaadin/testbench#2120
@mcollovati mcollovati force-pushed the issues/testbench-2120-test_for_click_cound_in_treegrid branch from 2adf17e to f3e98ac Compare March 6, 2026 16:11
@mcollovati mcollovati marked this pull request as ready for review March 6, 2026 16:12
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants