-
Notifications
You must be signed in to change notification settings - Fork 20
Add support for setting table connection name #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
dereuromark
wants to merge
42
commits into
vierge-noire:main
from
dereuromark:feat/set-connection-name
Closed
Add support for setting table connection name #268
dereuromark
wants to merge
42
commits into
vierge-noire:main
from
dereuromark:feat/set-connection-name
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Init Generator layer. * Fix tests. * Fix Psalm.
# Conflicts: # .github/workflows/ci.yml # README.md
Fix issue 226.
Add all method annotations to interface.
Updated PHP version in CI matrix and upgraded checkout action version. Added Codecov upload step for coverage reports.
Add coverage.
FactoryTransactionStrategy to reset without $fixtures.
Fix uniqueness for dummy.
Clarified the description of generator type guessing.
Add setConnection() method to BaseFactory and EventCollector to allow factories to use a different database connection. This enables testing scenarios where entities need to be persisted to specific connections. Changes: - Add connectionName property to EventCollector - Add setConnection() method to EventCollector and BaseFactory - Update getTable() to use custom connection when specified - Replace unset($this->table) with $this->table = null for consistency - Add test_dummy connection config for testing - Add tests for setConnection functionality Based on PR vierge-noire#257 with review feedback addressed (using = null instead of unset()). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Contributor
Author
|
Oops, my bad: dereuromark#11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
setConnection(string $connectionName)method toBaseFactoryandEventCollectorto allow factories to use a different database connectionunset($this->table)with$this->table = nullfor consistency (as suggested in review)Changes
connectionNameproperty toEventCollectorsetConnection()method toEventCollectorandBaseFactorywith fluent interfacegetTable()to use custom connection when specified viaConnectionManager::get()test_dummyconnection config in bootstrap for testingsetConnectionfunctionalityUsage
Test plan
setConnection()methodsetConnection()Based on PR #257 with review feedback addressed (using
= nullinstead ofunset()).🤖 Generated with Claude Code