python3-magic: update to 0.4.27. #58336
Open
+73
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srcpkgs/python3-magic/template
Outdated
| ( cd test/; python3 -m pytest ) | ||
| } | ||
| checksum=3978a25d43d9a7b8a89ae9d726bd4962fc90dc4f69ae852e399f3c56d4b0bd63 | ||
| make_check=no # tests no longer work. |
Member
There was a problem hiding this comment.
adding
checkdepends="python3-pytest"
make_check_pre="env LC_ALL=en_US.UTF-8"and backporting ahupp/python-magic@545a2a5 and ahupp/python-magic@4ffcd59 makes them work
Contributor
Author
There was a problem hiding this comment.
I reached the same conclusion after your first comment.
I identified those upstream commits afterwards, but hadn’t updated the template yet.
I’ll follow your suggestion and update the template accordingly.
Contributor
Author
There was a problem hiding this comment.
For context, the tests were already failing with the previous version as well when built against current libmagic. The changes you suggested make them pass again.
Rutpiv
force-pushed
the
python3-magic
branch
from
96dfa2a to
8caa244
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing