-
Notifications
You must be signed in to change notification settings - Fork 2.7k
ardour: update to 9.7. #61588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nazaradeh
wants to merge
1
commit into
void-linux:master
Choose a base branch
from
nazaradeh:ardour-update-9.7
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ardour: update to 9.7. #61588
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,40 +1,29 @@ | ||
| From 23d48d140720dfba8553616a2c27caf2b2166aff Mon Sep 17 00:00:00 2001 | ||
| From: Oliver Smith <ollieparanoid@postmarketos.org> | ||
| Date: Thu, 18 Jul 2024 23:44:34 +0200 | ||
| Subject: [PATCH] Unset HAVE_GNU_FTW | ||
|
|
||
| Don't assume we have GNU_FTW on Alpine. | ||
| # Don't assume we have GNU_FTW on musl-based systems. | ||
| # Let the build system detect whether it is available. | ||
| --- | ||
| libs/tk/ydk/config.h | 2 -- | ||
| libs/tk/ytk/config.h | 2 -- | ||
| 2 files changed, 4 deletions(-) | ||
|
|
||
| diff --git a/libs/tk/ydk/config.h b/libs/tk/ydk/config.h | ||
| index d933837df2..009d3303bf 100644 | ||
| index 484758b..7ee1d55 100644 | ||
| --- a/libs/tk/ydk/config.h | ||
| +++ b/libs/tk/ydk/config.h | ||
| @@ -26,8 +26,6 @@ | ||
| @@ -28,8 +28,6 @@ | ||
| #endif | ||
|
|
||
| #ifndef __APPLE__ | ||
| #if !defined(__APPLE__) && !defined(__NetBSD__) | ||
| -/* Have GNU ftw */ | ||
| -#define HAVE_GNU_FTW 1 | ||
| #endif | ||
|
|
||
| /* Define to 1 if ipc.h is available */ | ||
| diff --git a/libs/tk/ytk/config.h b/libs/tk/ytk/config.h | ||
| index f9991eee10..9f09e8d88a 100644 | ||
| index 7f648aa..3ecadb3 100644 | ||
| --- a/libs/tk/ytk/config.h | ||
| +++ b/libs/tk/ytk/config.h | ||
| @@ -23,8 +23,6 @@ | ||
| @@ -31,8 +31,6 @@ | ||
| #endif | ||
|
|
||
| #ifndef __APPLE__ | ||
| #if !defined(__APPLE__) && !defined(__NetBSD__) | ||
| -/* Have GNU ftw */ | ||
| -#define HAVE_GNU_FTW 1 | ||
| #endif | ||
|
|
||
| /* Define to 1 if ipc.h is available */ | ||
| -- | ||
| 2.45.2 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leave this header, it's useful context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or at least add a similar comment explaining why the patch is needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I regenerated the patch myself, so the header was removed. I'll add a comment back explaining the reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't add a comment, leave the original header. When you rebase a patch like that, you should still preserve the original provenance for proper attribution.