Skip to content

fix(global): run npm view in global mode - #2438

Merged
fengmk2 merged 3 commits into
voidzero-dev:mainfrom
jong-kyung:fix/global-npm-view-cwd
Aug 13, 2026
Merged

fix(global): run npm view in global mode#2438
fengmk2 merged 3 commits into
voidzero-dev:mainfrom
jong-kyung:fix/global-npm-view-cwd

Conversation

@jong-kyung

@jong-kyung jong-kyung commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

vp up -g now checks global package versions independently of the project it runs from. The registry lookup uses npm's global mode, matching the global install path, so project-level settings no longer cause npm view to fail and skip available updates.

Fixes #2437

@netlify

netlify Bot commented Aug 13, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit a05be89
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a7d3aaca3eb220007dbee89

@jong-kyung jong-kyung self-assigned this Aug 13, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fc42164169

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/vp_global_cli/src/commands/global/mod.rs Outdated
@liangmiQwQ
liangmiQwQ self-requested a review August 13, 2026 02:49
@jong-kyung
jong-kyung marked this pull request as draft August 13, 2026 02:51
@jong-kyung

Copy link
Copy Markdown
Collaborator Author

@liangmiQwQ Could you review this when you have a chance? 🙇‍♂️

@jong-kyung

Copy link
Copy Markdown
Collaborator Author

@codex review

@jong-kyung
jong-kyung marked this pull request as ready for review August 13, 2026 03:12

@liangmiQwQ liangmiQwQ left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

You can change the PR title btw

@jong-kyung jong-kyung changed the title fix(global): isolate npm view from project config fix(global): run npm view in global mode Aug 13, 2026
@jong-kyung

Copy link
Copy Markdown
Collaborator Author

Thanks a lot 💜 I updated the PR title too

@jong-kyung
jong-kyung requested a review from fengmk2 August 13, 2026 03:16
@fengmk2
fengmk2 merged commit 858ed05 into voidzero-dev:main Aug 13, 2026
65 of 67 checks passed
@jong-kyung
jong-kyung deleted the fix/global-npm-view-cwd branch August 13, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vp up -g skips all global packages with EBADDEVENGINES when run inside a project with devEngines.packageManager: pnpm

3 participants