fix(global): run npm view in global mode - #2438
Merged
Merged
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fc42164169
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
liangmiQwQ
self-requested a review
August 13, 2026 02:49
jong-kyung
marked this pull request as draft
August 13, 2026 02:51
Collaborator
Author
|
@liangmiQwQ Could you review this when you have a chance? 🙇♂️ |
Collaborator
Author
|
@codex review |
jong-kyung
marked this pull request as ready for review
August 13, 2026 03:12
liangmiQwQ
approved these changes
Aug 13, 2026
liangmiQwQ
left a comment
Collaborator
There was a problem hiding this comment.
LGTM 💯
You can change the PR title btw
Collaborator
Author
|
Thanks a lot 💜 I updated the PR title too |
fengmk2
reviewed
Aug 13, 2026
fengmk2
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vp up -gnow checks global package versions independently of the project it runs from. The registry lookup uses npm's global mode, matching the global install path, so project-level settings no longer causenpm viewto fail and skip available updates.Fixes #2437