Skip to content

refactor(fspy-shm): open backing files through sigsafe - #630

Closed
wan9chi wants to merge 1 commit into
refactor/fspy-shm-caller-pathfrom
feat/fspy-shm-injected-runtime
Closed

refactor(fspy-shm): open backing files through sigsafe#630
wan9chi wants to merge 1 commit into
refactor/fspy-shm-caller-pathfrom
feat/fspy-shm-injected-runtime

Conversation

@wan9chi

@wan9chi wan9chi commented Aug 10, 2026

Copy link
Copy Markdown
Member

Motivation

The injected runtime may attach before libc initialization on Linux, while Unix fspy_shm::open used std::fs::OpenOptions. This PR routes Unix backing-file opens through the sigsafe openat wrapper with a caller-owned path buffer. Linux uses the raw-syscall implementation; macOS uses sigsafe’s libSystem implementation. The existing fspy_shm API and storage behavior remain unchanged.

@wan9chi wan9chi changed the title feat/fspy shm injected runtime refactor(fspy-shm): open backing files through sigsafe Aug 10, 2026
@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

fspy benchmark

linux

dynamic/launch             change  +0.34%  [ -5.40% ..  +6.36%]  overhead   +51.81%
dynamic/access             change  -0.41%  [-20.01% ..  +5.52%]  overhead    +3.32%
dynamic/access-relative    change  -0.33%  [-13.98% ..  +4.17%]  overhead   +53.88%
static/launch              change  +1.27%  [ -5.66% ..  +8.75%]  overhead  +146.29%
static/access              change  +0.22%  [ -7.59% ..  +8.61%]  overhead  +702.51%
static/access-relative     change  -0.92%  [ -7.14% ..  +2.68%]  overhead +1133.10%

macos

dynamic/launch             change  +0.30%  [ -2.36% ..  +2.92%]  overhead  +239.91%
dynamic/access             change  +0.00%  [ -2.74% ..  +3.19%]  overhead    +1.42%
dynamic/access-relative    change  +1.09%  [ -3.75% ..  +3.75%]  overhead  +254.81%

windows

dynamic/launch             change  +0.13%  [ -2.68% ..  +5.17%]  overhead   +25.63%
dynamic/access             change  +0.00%  [ -0.76% ..  +1.14%]  overhead    +1.55%
dynamic/access-relative    change  +0.00%  [ -0.73% ..  +0.73%]  overhead    +1.29%

@wan9chi
wan9chi force-pushed the feat/fspy-shm-injected-runtime branch 3 times, most recently from ae067df to b990172 Compare August 11, 2026 02:17
@wan9chi
wan9chi changed the base branch from main to agent/fspy-shm-platform-modules August 11, 2026 02:18
@wan9chi
wan9chi force-pushed the feat/fspy-shm-injected-runtime branch from b990172 to b5a0003 Compare August 11, 2026 03:25
@wan9chi
wan9chi changed the base branch from agent/fspy-shm-platform-modules to refactor/fspy-shm-caller-path August 11, 2026 03:25
@wan9chi
wan9chi force-pushed the feat/fspy-shm-injected-runtime branch from b5a0003 to ccfba45 Compare August 11, 2026 04:24
Co-authored-by: GPT-5 Codex <codex@openai.com>
@wan9chi
wan9chi force-pushed the feat/fspy-shm-injected-runtime branch from ccfba45 to 7c0c84b Compare August 11, 2026 05:14
@wan9chi wan9chi closed this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant