Skip to content

refactor: organize CLI commands with category tags, add timeout flexibility#1492

Merged
MaojiaSheng merged 2 commits intovolcengine:mainfrom
MaojiaSheng:main
Apr 16, 2026
Merged

refactor: organize CLI commands with category tags, add timeout flexibility#1492
MaojiaSheng merged 2 commits intovolcengine:mainfrom
MaojiaSheng:main

Conversation

@MaojiaSheng
Copy link
Copy Markdown
Collaborator

This PR fixes: #1489

  • Add command category tags [Data], [Interactive], [Status], [Admin], [Experimental]
  • Add get_client_with_timeout() for custom timeout control
  • Version command now shows both CLI and server versions
  • Chat command falls back to config API key if VIKINGBOT_API_KEY not set
  • Improve auth error messages for better context
  • Reorganize command order with category comments

@github-actions
Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

1489 - Fully compliant

Compliant requirements:

  • Add command category tags [Data], [Interactive], [Status], [Admin], [Experimental]
  • Reorganize command order with category comments
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🏅 Score: 90
🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 Multiple PR themes

Sub-PR theme: Improve auth error messages

Relevant files:

  • openviking/server/auth.py

Sub-PR theme: Organize CLI commands with category tags and add timeout flexibility

Relevant files:

  • crates/ov_cli/src/main.rs

⚡ No major issues detected

@github-actions
Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

Copy link
Copy Markdown
Collaborator

@ZaynJarvis ZaynJarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MaojiaSheng MaojiaSheng merged commit 5dc5e31 into volcengine:main Apr 16, 2026
11 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Apr 16, 2026
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


openviking seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Feature] I'm optimization the sub-commands list of CLI

3 participants