[claude] fsst: ignored regression test for i32 offset overflow#7834
Closed
connortsui20 wants to merge 1 commit intodevelopfrom
Closed
[claude] fsst: ignored regression test for i32 offset overflow#7834connortsui20 wants to merge 1 commit intodevelopfrom
connortsui20 wants to merge 1 commit intodevelopfrom
Conversation
Merging this PR will improve performance by 30.52%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | new_alp_prim_test_between[f64, 32768] |
250.8 µs | 192.2 µs | +30.52% |
Comparing claude/fix-issue-7833-Qunwf (9aa32d9) with develop (eda04e1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #7832 — same regression test for #7833, but placed in the existing
encodings/fsst/src/tests.rsmodule instead of a newtests_large.rs, and gated with#[ignore]rather than thetest_withCI env attributes.The test allocates ~2.5 GiB for the input plus ~2.5 GiB for the compressed output, so it's too expensive to run by default even in CI. With
#[ignore]it's skipped on every normalcargo test/cargo nextestrun and can be invoked explicitly when needed:When the underlying overflow in
fsst_compress_iter(encodings/fsst/src/compress.rs:72, hardcodedVarBinBuilder::<i32>) is fixed, the trailingassert_eq!(compressed.len(), len)becomes the live regression assertion — just drop the#[ignore](or leave it, since the run cost is unchanged).Compared to #7832 this drops the
test-withdev-dependency, thetests_large.rsmodule, and the correspondingmod tests_large;inlib.rs.Tracks #7833.
🤖 Generated with Claude Code
Generated by Claude Code