Skip to content

Stop ignoring tests#7844

Merged
robert3005 merged 1 commit intodevelopfrom
rk/ignores
May 8, 2026
Merged

Stop ignoring tests#7844
robert3005 merged 1 commit intodevelopfrom
rk/ignores

Conversation

@robert3005
Copy link
Copy Markdown
Contributor

@robert3005 robert3005 commented May 8, 2026

These were ignored for reasons unknown. I removed ignores, fixed one case of
actually failing test and converted one of them to an expected panic

fix #7835

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/fix A bug fix label May 8, 2026
@robert3005 robert3005 requested a review from connortsui20 May 8, 2026 14:30

#[test]
#[ignore = "apply() has a bug with null propagation from struct validity to non-nullable child fields"]
#[should_panic = "Cannot create null scalar with non-nullable dtype i32"]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem right? Is this actually the correct behavior?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not the correct behaviour but instead of ignoring the test we let it run and assert it panics. This should be fixed and if someone fixes it this test will start failing

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but now nobody is tracking this issue? And now we are overloading should_panic with both "this is a test that should panic" and "this is a bug that someone needs to fix, without an actual reason". That was why I had those ignores, because they are easy to find.

@robert3005 robert3005 enabled auto-merge (squash) May 8, 2026 14:37
@robert3005 robert3005 merged commit fb2feb2 into develop May 8, 2026
83 of 84 checks passed
@robert3005 robert3005 deleted the rk/ignores branch May 8, 2026 14:37
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 8, 2026

Merging this PR will improve performance by 19.63%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 5 improved benchmarks
✅ 1203 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation patched_take_10k_adversarial 261.2 µs 230.9 µs +13.12%
Simulation patched_take_10k_dispersed 318.4 µs 288.1 µs +10.52%
Simulation patched_take_10k_first_chunk_only 304.7 µs 274.4 µs +11.06%
Simulation take_10k_first_chunk_only 273.1 µs 228.3 µs +19.63%
Simulation take_10k_dispersed 286.7 µs 241.8 µs +18.55%

Comparing rk/ignores (9fffef6) with develop (b212667)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run ignored tests on nightly CI

2 participants