fix: open editor without inspector global#1113
Draft
pupuking723 wants to merge 1 commit into
Draft
Conversation
✅ Deploy Preview for vue-devtools-docs canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #824.
When the Vite plugin is detected,
openInEditor()currently assumeswindow.__VUE_INSPECTOR__has been registered. If the inspector runtime does not register that global, the "Open in Editor" action throws before it can reach the Vite open-in-editor middleware.This keeps the existing inspector path when the global is available, and falls back to the same
__open-in-editor?file=...request shape used byvite-plugin-vue-inspectorwhen the global is missing.Verification:
pnpm exec vitest run packages/devtools-kit/__tests__/core/open-in-editor.test.ts --config /private/tmp/vue-devtools-vitest.config.tspnpm exec eslint packages/devtools-kit/src/core/open-in-editor/index.ts packages/devtools-kit/__tests__/core/open-in-editor.test.tspnpm build:devtools-kitgit diff --checkI also tried
pnpm type-check, but this checkout currently fails before reaching these files becausepackages/core/src/rpc/global.tsandpackages/core/src/rpc/vite.tscannot resolvehookable.