Skip to content

chore: pinning weave dependency#24

Open
chance-wnb wants to merge 1 commit into
mainfrom
chance/weave_pinning
Open

chore: pinning weave dependency#24
chance-wnb wants to merge 1 commit into
mainfrom
chance/weave_pinning

Conversation

@chance-wnb
Copy link
Copy Markdown
Collaborator

@chance-wnb chance-wnb commented Mar 25, 2026

pin an exact version of the weave npm dependency.

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@chance-wnb chance-wnb marked this pull request as ready for review March 25, 2026 00:28
@najaadd
Copy link
Copy Markdown

najaadd commented Mar 27, 2026

npm install is lockfile-aware and verifies downloaded tarballs, but it can update the lockfile and is not fail-closed when package.json and package-lock.json diverge.

For CI, npm ci is the safer choice because it requires the lockfile to match, removes existing node_modules, and never writes the lockfile.

Also, since this is primarily consumed via npm install -g, the repo’s package-lock.json does not protect end users anyway, because package-lock.json is not published. If you want stronger supply-chain security for the published CLI, provenance on the npm package would be better!

@chance-wnb chance-wnb force-pushed the chance/weave_pinning branch from 4bc5a2e to fe272ae Compare March 27, 2026 21:33
@chance-wnb
Copy link
Copy Markdown
Collaborator Author

If you want stronger supply-chain security for the published CLI, provenance on the npm package would be better!

Thanks, it seems the ask is to add "provenance on the npm package". AFAIK, this can only be properly done if the repository is public. I will do such after the repository can be open to public.

@chance-wnb chance-wnb requested a review from najaadd March 30, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants