Skip to content

v2 testing bugfixes#177

Closed
casey-coreweave wants to merge 4 commits into
v2from
cabernathy/v2_testing_bugfixes
Closed

v2 testing bugfixes#177
casey-coreweave wants to merge 4 commits into
v2from
cabernathy/v2_testing_bugfixes

Conversation

@casey-coreweave
Copy link
Copy Markdown
Contributor

@casey-coreweave casey-coreweave commented May 13, 2026

Route /bucket Through nginx-proxy

When the server manifest enables the proxy feature, /bucket should be served by the generated nginx-proxy application rather than by separate infrastructure routes directly to object storage. This updates the v2 route builders so nginx-proxy owns the /bucket path in generated Ingress/HTTPRoute configuration and skips managed bucket infra routes in that mode. That removes the need for shim-created extra Ingress/HTTPRoute resources while preserving direct infra routing when the proxy feature is not enabled.

Derive Object Store Proxy Upstreams

Object store proxy configuration now derives explicit proxy fields from the managed or external object store connection secret. The operator emits a proxy scheme, upstream address, Host header value, and TLS SNI name, then wires those into the generated nginx config. This lets local and S3-compatible HTTP upstreams work correctly without rewriting proxy_pass by hand, while still preserving proper Host/SNI behavior for HTTPS object stores.

Ignore Missing Completed Migration Jobs

The v2 reconciler now treats NotFound as success when cleaning up migration Jobs after migration status is already complete. This makes migration cleanup idempotent across reconciles and prevents unrelated networking reconciliation from failing just because a previously completed migration Job was already deleted.

Default NGINX Ingress Upload Annotations

For nginx-backed Ingress resources, the operator now defaults annotations needed for large payload uploads and long object-store operations: unlimited body size plus longer read/send timeouts. These defaults are added through CR defaulting and applied when rendering the consolidated Ingress, while user-provided annotations still take precedence. This keeps common object upload/download paths working out of the box without requiring manual ingress shim annotations.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e76848e5-6fc1-4cd4-9040-8b3cb88db894

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cabernathy/v2_testing_bugfixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant