v2 testing bugfixes#177
Closed
casey-coreweave wants to merge 4 commits into
Closed
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route /bucket Through nginx-proxy
When the server manifest enables the proxy feature, /bucket should be served by the generated nginx-proxy application rather than by separate infrastructure routes directly to object storage. This updates the v2 route builders so nginx-proxy owns the /bucket path in generated Ingress/HTTPRoute configuration and skips managed bucket infra routes in that mode. That removes the need for shim-created extra Ingress/HTTPRoute resources while preserving direct infra routing when the proxy feature is not enabled.
Derive Object Store Proxy Upstreams
Object store proxy configuration now derives explicit proxy fields from the managed or external object store connection secret. The operator emits a proxy scheme, upstream address, Host header value, and TLS SNI name, then wires those into the generated nginx config. This lets local and S3-compatible HTTP upstreams work correctly without rewriting proxy_pass by hand, while still preserving proper Host/SNI behavior for HTTPS object stores.
Ignore Missing Completed Migration Jobs
The v2 reconciler now treats NotFound as success when cleaning up migration Jobs after migration status is already complete. This makes migration cleanup idempotent across reconciles and prevents unrelated networking reconciliation from failing just because a previously completed migration Job was already deleted.
Default NGINX Ingress Upload Annotations
For nginx-backed Ingress resources, the operator now defaults annotations needed for large payload uploads and long object-store operations: unlimited body size plus longer read/send timeouts. These defaults are added through CR defaulting and applied when rendering the consolidated Ingress, while user-provided annotations still take precedence. This keeps common object upload/download paths working out of the box without requiring manual ingress shim annotations.