fix: update brace-expansion to resolve GHSA-rgw5-rvv9-x895 (DEVX-8505) - #92
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
fix: update brace-expansion to resolve GHSA-rgw5-rvv9-x895 (DEVX-8505)#92warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
Bumps transitive brace-expansion (via minimatch) from 1.1.17 -> 1.1.18 and 2.1.3 -> 2.1.4 in package-lock.json to pick up the fix for GHSA-rgw5-rvv9-x895, a denial-of-service vulnerability caused by unbounded intermediate arrays built before combine(). No package.json changes were needed; both minimatch dependents already declare semver ranges (^1.1.7, ^2.0.1) that permit the patched versions. Co-Authored-By: Warp <agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves GHSA-rgw5-rvv9-x895 (high severity denial-of-service in
brace-expansion) for DEVX-8505.This advisory covers an incomplete fix from the earlier
maxLengthmitigation (GHSA-mh99-v99m-4gvg / CVE-2026-14257): intermediate arrays built beforecombine()are still unbounded, so a ~25 KB input can trigger an uncatchable Node OOM, and a ~400 KB padded-sequence input can block the event loop for minutes.Two Dependabot alerts were filed against this repo's
package-lock.json, both at development scope, and both were auto-dismissed by GitHub at creation under Dependabot's dev-scope auto-triage rule — there was no open Dependabot PR:< 1.1.18, first patched version1.1.182.1.4Given the dev-only scope and auto-dismissed status, this is a low-risk, build/tooling-only exposure, but the fix is cheap so we're closing it out proactively.
Changes
package-lock.json: bumped the transitivebrace-expansiondependency (pulled in viaminimatch) from1.1.17→1.1.18and from2.1.3→2.1.4.package.jsonchanges were needed — the fix was achieved with a targetednpm update brace-expansion, since bothminimatchdependents (minimatch@3.1.5requiring^1.1.7,minimatch@9.0.9requiring^2.0.2) already declare semver ranges that permit the patched versions. Nooverridesentry was required.Before / after
Before (
npm ls brace-expansion --all):After:
Verification
npm update brace-expansion— lockfile refresh,found 0 vulnerabilities.rm -rf node_modules && npm ci— clean install succeeds,found 0 vulnerabilities.npm ls brace-expansion --all— confirms only patched versions (1.1.18,2.1.4) remain in the tree.npm run lint(eslint .) — passes with no errors.npm run build(tsc lib/*.ts && next build) — fails withError: appId is missingwhile collecting page data (Algolia search config not available in this sandbox). Confirmed this same failure occurs identically onmainwith a clean install, so it is unrelated to this change and pre-existing in this environment.Ref: DEVX-8505