[Completions] Bump command-signatures to 491864c0 (nx run fix) - #15114
Closed
warp-agent-staging[bot] wants to merge 1 commit into
Closed
[Completions] Bump command-signatures to 491864c0 (nx run fix)#15114warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
Contributor
Author
|
This PR was generated with Warp.   |
warp-agent-staging
Bot
force-pushed
the
factory/bump-command-signatures-nx-graph-fix
branch
from
August 14, 2026 00:02
43cca55 to
3d12b54
Compare
Points at warpdotdev/command-signatures#335 (merged), which fixes `nx run <TAB>` completions (APP-5384 / #4691) by switching the workspace_targets generator from the broken `nx graph --print` / tmpfile fallback chain to `nx graph --file=stdout`. Co-Authored-By: Warp Agent <agent@warp.dev>
warp-agent-staging
Bot
force-pushed
the
factory/bump-command-signatures-nx-graph-fix
branch
from
August 14, 2026 00:12
3d12b54 to
ca1f10e
Compare
warp-agent-staging
Bot
changed the title
Contributor
Author
|
Closing as superseded. #15109 bumped the pin to Merging this now would move the pin backwards and revert the kubectl context forwarding that came with #15109. Responding as wilson: Open session · View factory task |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps the
warp-command-signaturespin to pick up the fix fornx run <TAB>completions producing no suggestions (APP-5384 / #4691). command-signatures#335 has merged (squash commit491864c0f695a32b77bef0942fe0f6cb54cb1567onmain), and this PR now points directly at that commit — theworkspace_targetsgenerator now usesnx graph --file=stdoutinstead of the broken--print/tmpfile fallback chain.This repo pins
command-signaturesby commitrev(not a published version), so the fix does not reach users until this pin is bumped — that's the only purpose of this PR.Linked Issue
Nx,npm, and more #4691Testing
No
warpsource was changed, only thecommand-signaturesdependency pin. Verified:cargo metadata --locked --no-deps— passes (lockfile is internally consistent for the manifest, no further resolution needed).cargo check -p warp_completer --locked(the crate that consumeswarp-command-signatures) — fetches commit491864c0and compiles cleanly.Diff is minimal:
Cargo.toml'srevfield plus the two matchingsource = "git+...?rev=..."lines inCargo.lockforwarp-command-signatures/warp-completion-metadata— no unrelated dependency edges.The underlying generator fix was verified against real Nx workspaces on
nx@20.3.0andnx@23.1.1in command-signatures#335 — see that PR for the transcript.I have manually tested my changes locally with
./script/run(not applicable: dependency-pin-only change with nowarpsource changes; verified viacargo check --lockedinstead, see above)Agent Mode
CHANGELOG-BUG-FIX: Fixed
nx run <TAB>completions producing no suggestions on Nx versions prior to 21.6.