Merged
Conversation
Some mocks generated by moq replaced by mockery mocks. Tests updated. Private interface stateWrapper renamed to cleanerState. Separate mock for this interface replaced with global state mock.
alexeykiselev
added
wip
alexeykiselev
removed
wip
nickeskov
reviewed
Mar 11, 2026
Comment on lines
+402
to
+403
| unsetMockCalls(&e.me.Mock, "libVersion") | ||
| unsetMockCalls(&e.me.Mock, "setLibVersion") |
Collaborator
There was a problem hiding this comment.
Suggest to add tests for these methods names (similar above and below). Can be helpful in renaming/refactoring process. Tests can be written with reflect package, I guess.
pkg/ride/tree_evaluation_test.go
Outdated
Comment on lines
+4489
to
+4494
| var aliasCalls []mock.Call | ||
| for _, c := range env.ms.Calls { | ||
| if c.Method == "NewestAddrByAlias" { | ||
| aliasCalls = append(aliasCalls, c) | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Can be replaced to countMockCalls
Collaborator
Author
There was a problem hiding this comment.
Actually this check can be safely removed. All calls already added to expectations, and expectations checks registered in NewMockEnvironment function.
I tried to add one more expectation of this call here and test failed.
nickeskov
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.