feat: deprecate async_enabled replication argument removed server-side#2050
Open
LijuanTang94 wants to merge 1 commit into
Open
feat: deprecate async_enabled replication argument removed server-side#2050LijuanTang94 wants to merge 1 commit into
async_enabled replication argument removed server-side#2050LijuanTang94 wants to merge 1 commit into
Conversation
The `asyncEnabled` field was removed from the Weaviate server schema in v1.38. The client still accepted `async_enabled` and forwarded it, so the server silently dropped it and the user's intent was lost without any indication (issue weaviate#2047). Following the existing precedent for `max_workers` / `alive_nodes_checking_frequency` (Dep029), the `async_enabled` argument in `Configure.replication` / `Reconfigure.replication` now emits a `DeprecationWarning` (Dep030) when passed, while remaining functional against older servers. Docstrings are updated to document the removal. Closes weaviate#2047
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
Author
|
I have read the CLA Document and I hereby agree to the terms of the CLA.
获取 Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
发件人: Weaviate Git Bot ***@***.***>
发送时间: Sunday, May 31, 2026 4:00:56 PM
收件人: weaviate/weaviate-python-client ***@***.***>
抄送: Lijuan Tang ***@***.***>; Author ***@***.***>
主题: Re: [weaviate/weaviate-python-client] feat: deprecate `async_enabled` replication argument removed server-side (PR #2050)
[https://avatars.githubusercontent.com/u/83967968?s=20&v=4]weaviate-git-bot left a comment (weaviate/weaviate-python-client#2050)<#2050 (comment)>
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement<https://weaviate.io/service/contributor-license-agreement>. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.
beep boop - the Weaviate bot 👋🤖
PS:
Are you already a member of the Weaviate Forum?<https://forum.weaviate.io/>
—
Reply to this email directly, view it on GitHub<#2050?email_source=notifications&email_token=BEY3V5HHLE24WPHDMEBFOYD45S2SRA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJYHA2DQOJQGIY2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4588489021>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BEY3V5D7NK32NISWJNKZ3PD45S2SRAVCNFSM6AAAAACZUX23SSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DKOBYGQ4DSMBSGE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2047
The
asyncEnabledfield was removed from the Weaviate server schema in v1.38 (weaviate/weaviate#11214). The client still acceptedasync_enabledand forwarded it on the write path, so the server silently dropped it — the user's intent was lost without any indication.This PR adds a
DeprecationWarningso the silent loss becomes visible, following the exact precedent the maintainers established formax_workers/alive_nodes_checking_frequency(Dep029) when thoseasync_configfields were removed in v1.37.3.Approach
I deliberately chose deprecate-and-warn over hard removal (the issue's step 3 offers both):
async_enabledkwarg outright would break any existing user code callingConfigure.replication(async_enabled=...).If the maintainers prefer to also drop the read-path field (
_ReplicationConfig.async_enabled+ the parser inconfig_methods.py, which now always reports a misleadingFalse), I'm happy to extend the PR — I left it out to keep this change focused and non-breaking, and because removing a read attribute is a larger compatibility decision.Changes
weaviate/warnings.py— newDep030deprecation warningweaviate/collections/classes/config.py—Configure.replicationandReconfigure.replicationemit the warning whenasync_enabledis passed; docstrings updatedtest/collection/test_config.py— tests that the warning fires whenasync_enabledis passed and stays silent otherwise (both factories)Testing