Skip to content

chore: add issue templates and rework PR template#232

Merged
vishnuv688 merged 1 commit into
mainfrom
vv/pull-request-and-issue-template
Jun 17, 2026
Merged

chore: add issue templates and rework PR template#232
vishnuv688 merged 1 commit into
mainfrom
vv/pull-request-and-issue-template

Conversation

@vishnuv688

Copy link
Copy Markdown
Member

What

Why

How


Architecture self-check

Required for every non-trivial PR. If a box is unchecked, explain why.

  • No new duplication. This PR does not add a type, constant, enum, or contract that already exists in another package. (If it consolidates one, note which item from CLAUDE.md §7 is being resolved.)
  • No cross-adapter imports. No code in service, nightwatch-devtools, or selenium-devtools imports from another adapter.
  • No adapter imports in backend / app. Neither package reaches into adapter internals.
  • Typed contracts at boundaries. Any new fetch(...), ws.send(...), or HTTP route has a typed request/response shape in shared (or in service types if shared doesn't exist yet, with a TODO to move).
  • No if (framework === '...') outside an adapter. Framework branching uses a typed FrameworkId.
  • No new any at package boundaries. Internal any is acceptable only at a documented framework-edge with a one-line comment.

Multi-adapter changes

  • This PR touches more than one adapter package.

If checked: why isn't this in core? Answer here:


Debt scoreboard

List the CLAUDE.md §7 debt items this PR resolves, partially resolves, or extends. Delete this section only if the PR genuinely affects no debt items.

  • Resolved: <item, or "none">
  • Partially resolved: <item, or "none">
  • New debt introduced: <item, or "none — and explain why if any>

If new debt is introduced, it must be added to CLAUDE.md §7 in this PR.


Testing

  • Unit tests for new logic in shared / core (required per CLAUDE.md §4).
  • Regression test for any bug fix (required per CLAUDE.md §4).
  • pnpm build passes.
  • pnpm test passes.
  • pnpm lint passes.
  • For UI/runtime changes: verified in example/ (or example for the framework I changed).

If any required item is skipped, say so here with the reason:

<your note, or "n/a">


Screenshots / recordings (UI changes only)

@vishnuv688 vishnuv688 marked this pull request as ready for review June 17, 2026 11:52
@vishnuv688 vishnuv688 merged commit 73a0ebb into main Jun 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant