Skip to content

Update element adoption logic for scoped registry #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ja-y-son wants to merge 8 commits into
base: main
Choose a base branch
from
+34 −17
Open

Update element adoption logic for scoped registry #1437

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cfc5109
Modify element adoption SCER
Dec 2, 2025
1dc85e4
Use effective global custom element registry as discussed
Dec 2, 2025
697020b
Update steps
Dec 2, 2025
ee404fe
Fix indentation
Dec 2, 2025
a334c2a
Fix fix indentation
Dec 2, 2025
90fc49c
simply logic
Dec 5, 2025
79b21f3
Update dom.bs
ja-y-son Dec 8, 2025
fdf7749
Update build.yml
annevk Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions dom.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6083,8 +6083,26 @@ algorithm is passed <var ignore>node</var> and <var ignore>oldDocument</var>, as
<li><p>If <var>inclusiveDescendant</var>'s <a for=Element>custom element registry</a> is null
or <var>inclusiveDescendant</var>'s <a for=Element>custom element registry</a>'s
<a for=CustomElementRegistry>is scoped</a> is false, then set
<var>inclusiveDescendant</var>'s <a for=Element>custom element registry</a> to
<var>document</var>'s <a>effective global custom element registry</a>.
<var>inclusiveDescendant</var>'s <a for=Element>custom element registry</a> based on the
following conditions:

<ol>
<li><p>If <var>inclusiveDescendant</var>'s <a for=tree>parent</a> is null or
<var>inclusiveDescendant</var>'s <a for=tree>parent</a> is a {{DocumentFragment}} but not
a {{ShadowRoot}}, then set <var>inclusiveDescendant</var>'s
<a for=Element>custom element registry</a> to <var>document</var>'s
<a>effective global custom element registry</a>.

<li><p>If <var>inclusiveDescendant</var>'s <a for=tree>parent</a>'s
<a for=Element>custom element registry</a> is null or is equal to <var>document</var>'s
<a>effective global custom element registry</a>, then set <var>inclusiveDescendant</var>'s
<a for=Element>custom element registry</a> to <var>inclusiveDescendant</var>'s
<a for=tree>parent</a>'s <a for=Element>custom element registry</a>.
Copy link
Member

@annevk annevk Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this not using the "effective global custom element registry" strategy discussed? It's not clear to me this is the same or why we need to be looking at document at all.

Copy link
Contributor Author

@ja-y-son ja-y-son Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use "effective global custom element registry" strategy as discussed. Was trying to see if I could get the point across with another approach but it seems like "effective global custom element registry" is still the better way to go. Lmk if I'm missing anything on this idea.


<li><p>Otherwise, set <var>inclusiveDescendant</var>'s
<a for=Element>custom element registry</a> to <var>document</var>'s
<a>effective global custom element registry</a>.
</ol>
</ol>
</ol>

Expand Down