Skip to content

fix: update self-references after repo rename to wherobots-cli - #34

Merged
ClayMav merged 1 commit into
mainfrom
clay/wbc-758-rename-self-references
Jul 21, 2026
Merged

fix: update self-references after repo rename to wherobots-cli#34
ClayMav merged 1 commit into
mainfrom
clay/wbc-758-rename-self-references

Conversation

@ClayMav

@ClayMav ClayMav commented Jul 21, 2026

Copy link
Copy Markdown
Member

Summary

The GitHub repo wherobots/wbc-cli was renamed to wherobots/wherobots-cli. This updates all internal self-references so the CLI's self-upgrade, background update-check, install script, and docs point at the new name.

Linear: WBC-758

Why

GitHub currently redirects the old wherobots/wbc-cli path, so nothing is broken today. But that redirect lapses the moment anyone recreates a repo named wbc-cli under the org — at which point:

  • wherobots upgrade (self-upgrade) would fetch releases from the wrong repo
  • the background update-check would query the wrong repo

Pointing every internal reference at the real name makes behavior correct regardless of redirects.

Changes

File Change
internal/version/check.go repo constant used for update-check
internal/commands/upgrade.go upgradeRepo constant used for self-upgrade
scripts/install-release.sh default REPO + usage/help text
README.md raw install URLs, git clone URL, and clone directory (cd wherobots-cli)
RELEASE.md gh api repos/... release-notes path

Not changed: go.mod module path (wherobots/cli) and the binary name (wherobots) — both independent of the repo name.

Verification

  • go build ./... — clean
  • go test ./... — all pass (incl. internal/version, internal/commands)
  • gofmt -l internal/ — clean; go vet ./... — clean
  • End-to-end install against the real release with the updated script:
    bash scripts/install-release.sh --tag latest-prerelease --install-dir <dir>
    # Downloading wherobots_darwin_arm64 from wherobots/wherobots-cli@latest-prerelease...
    # Verifying checksum... Installed: <dir>/wherobots
    <dir>/wherobots --version
    # wherobots version latest-prerelease (commit e1dbb7d..., built 2026-07-08T...)
    
    Confirms the download + checksum path resolves correctly against wherobots/wherobots-cli.

Follow-up

A new release should be cut after merge so that already-installed binaries (which still carry the old wherobots/wbc-cli constant) self-upgrade against the new repo name.

The GitHub repo wherobots/wbc-cli was renamed to wherobots/wherobots-cli
(WBC-758). The CLI's self-upgrade command and background update-check, plus
the install script and docs, still pointed at the old owner/name.

GitHub redirects the old path for now, so nothing is broken today. But
redirects lapse the moment someone recreates a repo named wbc-cli, at which
point self-upgrade and update-check would silently hit the wrong repo. Point
every internal reference at the real name so behavior is correct regardless of
redirects.

Changes:
- internal/version/check.go: update-check repo constant
- internal/commands/upgrade.go: self-upgrade repo constant
- scripts/install-release.sh: default REPO and usage text
- README.md: raw install URLs, git clone URL, and clone dir
- RELEASE.md: gh api repos/... path

go.mod module path (wherobots/cli) and the binary name are unaffected.
@ClayMav
ClayMav marked this pull request as ready for review July 21, 2026 17:22
@ClayMav
ClayMav requested a review from a team as a code owner July 21, 2026 17:22

@salty-hambot salty-hambot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by Salty Hambot 🤖🧂 — rubric mode

Verdict: ✅ pass

Dimension Verdict Notes
correctness ✅ pass Repo string updated consistently in all four self-referencing locations; no logic touched.
security ✅ pass No auth, injection, or credential handling changed — pure string rename.
privacy ✅ pass No data handling or PII surface affected.
reliability ✅ pass Existing binaries carry the old constant until a fresh release cuts, but the author already flagged this follow-up; no regression in the code itself.
scalability ✅ pass No performance or load-bearing paths touched.
observability ✅ pass Log/error messages already reference the constant, so they update transitively; nothing to add.
clarity/maintainability ✅ pass Rename improves clarity by matching the actual repo name; docs and code stay in sync.
test quality ✅ pass No existing tests hardcode the repo string, so nothing breaks and no new tests are warranted for a rename.

Textbook find-and-replace rename to wherobots-cli — consistent across README, RELEASE.md, both Go constants, and the install script, with no stale wbc-cli stragglers. Ship it (and don't forget to cut that fresh release so old binaries can self-heal).

0 finding(s) posted · 1 skipped as already raised.
💰 Review cost: $0.4951 · 469.1k in / 4.3k out tokens · ⏱️ 3m13.6s
💬 To request a re-review, comment @salty-hambot review

@ClayMav
ClayMav merged commit 2971a7a into main Jul 21, 2026
3 checks passed
@ClayMav
ClayMav deleted the clay/wbc-758-rename-self-references branch July 21, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants