WIP: point z-axis up, change some settings for OrbitControls#272
Draft
mgeier wants to merge 2 commits intowidgetti:masterfrom
Draft
WIP: point z-axis up, change some settings for OrbitControls#272mgeier wants to merge 2 commits intowidgetti:masterfrom
mgeier wants to merge 2 commits intowidgetti:masterfrom
Conversation
Contributor
Author
|
I've been mixing a few things here, I've made a separate PR that isolates the "enable panning" feature: #273. |
maartenbreddels
force-pushed
the
master
branch
2 times, most recently
from
e861e87 to
6dead3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I really like this project, but one thing I always found irritating was the behavior of the mouse controls for rotation.
There have been some discussions before, e.g.:
I've tried to hopefully improve on that, but I guess some of it might not be the right way to do it. I'm hoping for plentiful feedback!
These are the changes I intended:
OrbitControls), and select the "good" panning modeI might have done some unintended changes and it's quite likely that I've completely broken something.
I'm mostly interested in the "orbit" controls, I don't see why anyone would want the "trackball" controls (now that the "orbit" controls work much better).
I'm not sure what the initial camera position should be ...