Feature: Lights and Shadows Merge#341
Open
rinftech-github wants to merge 2 commits intowidgetti:masterfrom
Open
Feature: Lights and Shadows Merge#341rinftech-github wants to merge 2 commits intowidgetti:masterfrom
rinftech-github wants to merge 2 commits intowidgetti:masterfrom
Conversation
added 2 commits
August 10, 2020 15:56
Add lighting and shadowmap support
rinftech-github
changed the title
4 tasks
maartenbreddels
force-pushed
the
master
branch
2 times, most recently
from
e861e87 to
6dead3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Squashed and merged with master.
Should replace #308
Added lighting and shadowmap support for plot_mesh, plot_trisurf, plot_surface.
Scatter supports lighting but does not support shadowmapping because of an existing Three.JS issue:
#276
I encountered scaling issues with mesh and scatter plots caused most likely by previous pull request changes.