Skip to content

Conversation

@emmartins
Copy link
Contributor

@bstansberry
Copy link
Contributor

Thanks @emmartins.

I'd like to better understand the scope of this.

My guesstimate is:

  1. It adds the EE 11 version xsds where EE Concurrency types are valid.
  2. It adds test documents using those xsds that exercise the new EE concurrency types.
  3. It adds a few other xsds in the web area that I guess are referenced by web-app_6.1.xsd? (Maybe the others reference EE concurrency types directly; I didn't look carefully.)
    It adds handling of the new concurrency elements/attributes.
  4. It adds test assertions of those elements.
  5. For the schemas it adds, other than the concurrency stuff it DOES NOT make any attempt to handle or test parsing of anything else that's new in the schema.

@emmartins
Copy link
Contributor Author

You got it all right 🙂

*
* @return the value of virtual
*/
public Boolean getVirtual() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: get instead of is seems commonly used in this repo, so ok with me:

$ git grep "oolean get"
common/src/main/java/org/jboss/metadata/javaee/spec/DataSourceMetaData.java:    public boolean getTransactional() {
common/src/main/java/org/jboss/metadata/javaee/spec/JMSConnectionFactoryMetaData.java:    public boolean getTransactional() {
common/src/main/java/org/jboss/metadata/javaee/spec/PortComponent.java:    public boolean getSecureWSDLAccess() {
common/src/main/java/org/jboss/metadata/parser/util/XMLResourceResolver.java:        public boolean getCertifiedText() {
ear/src/main/java/org/jboss/metadata/ear/spec/EarMetaData.java:    public boolean getInitializeInOrder() {
ejb/src/main/java/org/jboss/metadata/ejb/spec/RemoveMethodMetaData.java:    public Boolean getRetainIfException() {
web/src/main/java/org/jboss/metadata/web/jboss/JBossWebMetaData.java:    public Boolean getJaccAllStoreRole() {
web/src/main/java/org/jboss/metadata/web/jboss/JBossWebMetaData.java:    public Boolean getDenyUncoveredHttpMethods() {
web/src/main/java/org/jboss/metadata/web/jboss/JBossWebMetaData.java:    public Boolean getProactiveAuthentication() {
web/src/main/java/org/jboss/metadata/web/spec/CookieConfigMetaData.java:    public boolean getHttpOnly() {
web/src/main/java/org/jboss/metadata/web/spec/CookieConfigMetaData.java:    public boolean getSecure() {
web/src/main/java/org/jboss/metadata/web/spec/CookieConfigMetaData.java:    public boolean getHttpOnlySet() {
web/src/main/java/org/jboss/metadata/web/spec/CookieConfigMetaData.java:    public boolean getSecureSet() {
web/src/main/java/org/jboss/metadata/web/spec/CookieConfigMetaData.java:    public boolean getMaxAgeSet() {
web/src/main/java/org/jboss/metadata/web/spec/FilterMetaData.java:    public boolean getAsyncSupportedSet() {
web/src/main/java/org/jboss/metadata/web/spec/MultipartConfigMetaData.java:    public boolean getMaxFileSizeSet() {
web/src/main/java/org/jboss/metadata/web/spec/MultipartConfigMetaData.java:    public boolean getMaxRequestSizeSet() {
web/src/main/java/org/jboss/metadata/web/spec/MultipartConfigMetaData.java:    public boolean getFileSizeThresholdSet() {
web/src/main/java/org/jboss/metadata/web/spec/ServletMetaData.java:    public boolean getLoadOnStartupSet() {
web/src/main/java/org/jboss/metadata/web/spec/ServletMetaData.java:    public boolean getAsyncSupportedDefault() {
web/src/main/java/org/jboss/metadata/web/spec/ServletMetaData.java:    public boolean getAsyncSupportedSet() {
web/src/main/java/org/jboss/metadata/web/spec/ServletMetaData.java:    public boolean getEnabledDefault() {
web/src/main/java/org/jboss/metadata/web/spec/ServletMetaData.java:    public boolean getEnabledSet() {
web/src/main/java/org/jboss/metadata/web/spec/SessionConfigMetaData.java:    public boolean getSessionTimeoutSet() {
web/src/main/java/org/jboss/metadata/web/spec/WebMetaData.java:    public Boolean getDenyUncoveredHttpMethods() {

@bstansberry bstansberry merged commit df42bfc into wildfly:main Jun 23, 2025
4 checks passed
@bstansberry
Copy link
Contributor

Thanks @emmartins.

There are various JBMETAs for adding handling of various EE 11 specs; I added comments to those noting that part but not all of the work was done here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants