Skip to content

cannon: Delete obsolete wsOpts#5017

Closed
akshaymankar wants to merge 2 commits intodevelopfrom
ws-options
Closed

cannon: Delete obsolete wsOpts#5017
akshaymankar wants to merge 2 commits intodevelopfrom
ws-options

Conversation

@akshaymankar
Copy link
Member

This option was never exposed in the helm chart config, so noone ever configured it. The code using this was removed in
#4994

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

This option was never exposed in the helm chart config, so noone ever configured
it. The code using this was removed in
#4994
@akshaymankar akshaymankar requested review from a team as code owners February 9, 2026 13:48
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Feb 9, 2026
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@akshaymankar
Copy link
Member Author

This is actually used in rabbitmq code. I'll close this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants