fix(deps): allow higher version of importlib-resources for python 3.9 and above#107
Closed
aberlioz wants to merge 1 commit intowiremock:masterfrom
Closed
fix(deps): allow higher version of importlib-resources for python 3.9 and above#107aberlioz wants to merge 1 commit intowiremock:masterfrom
importlib-resources for python 3.9 and above#107aberlioz wants to merge 1 commit intowiremock:masterfrom
Conversation
Author
|
Hello @oleg-nenashev 👋🏻 , |
Member
|
Cc @leeturner |
Contributor
|
Fixed in - #120 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pin on version
^5.12.0of package importlib-resources was introduced in this PR: #60It prevents applications running on higher versions of python to install the newest
importlib-resourcesversions.Considering the usage of the lib, one can argue that we don't even need this dependencies for python version 3.9 and above.
References
Submitter checklist
#help-contributingor a project-specific channel like#wiremock-java