More robust SFTP send/read handling#882
More robust SFTP send/read handling#882JacobBarthelmeh wants to merge 3 commits intowolfSSL:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request addresses robust SFTP send/read handling (ZD21253) by fixing error handling logic and adding extensive testing for large file transfers.
Changes:
- Corrected error handling logic in
wolfSSH_SFTP_SendReadPacketto properly handle retriable vs fatal errors - Updated cache keys in CI workflow to include keygen configuration
- Added comprehensive large file transfer test (3GB file with 10MB chunks)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/wolfsftp.c | Fixed inverted error handling logic in 4 locations to properly distinguish between retriable errors (WS_WANT_READ/WRITE) and fatal errors |
| .github/workflows/sftp-test.yml | Updated cache keys, added --enable-keygen to wolfssl build, added new large file transfer test job, and minor whitespace cleanup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JacobBarthelmeh
force-pushed
the
sftp
branch
from
d5efc9c to
0dbe27f
Compare
JacobBarthelmeh
force-pushed
the
sftp
branch
from
0dbe27f to
352db62
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JacobBarthelmeh
force-pushed
the
sftp
branch
from
352db62 to
8925b49
Compare
JacobBarthelmeh
force-pushed
the
sftp
branch
from
8925b49 to
58b6611
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JacobBarthelmeh
force-pushed
the
sftp
branch
from
fddd48a to
d67a781
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JacobBarthelmeh
force-pushed
the
sftp
branch
from
d67a781 to
88263dd
Compare
JacobBarthelmeh
force-pushed
the
sftp
branch
from
88263dd to
361c288
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JacobBarthelmeh
force-pushed
the
sftp
branch
from
361c288 to
3538045
Compare
JacobBarthelmeh
force-pushed
the
sftp
branch
from
3538045 to
0ab5c69
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JacobBarthelmeh
force-pushed
the
sftp
branch
from
0ab5c69 to
30ea988
Compare
ZD21253